Son of Alexander Cunningham Weir and Isabella Weir, Bellard, Kilmacolm. 

Husband of Anne MacPherson Weir, 17 Beaumont Gate, Glasgow. Brother of Sir Cecil McAlpine Weir who served with the Cameronians and Tank Corps.

Died of wounds received in action in Palestine. Remembered as a member of Troon Golf Club.